Skip to content

Replace 'Resuming work' comment with investigation findings gate and simplify rubrics#149

Merged
sebastientaggart merged 1 commit into
devfrom
feature/148-simplify-skill-rubrics
Apr 24, 2026
Merged

Replace 'Resuming work' comment with investigation findings gate and simplify rubrics#149
sebastientaggart merged 1 commit into
devfrom
feature/148-simplify-skill-rubrics

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

Replace the unconditional "Resuming work" comment in /start Case B with a conditional investigation findings gate — only post to the ticket when the agent discovers something novel and durable, with a simple post / skip choice. If nothing noteworthy was found, skip silently.

Simplify over-specified rubrics in both /start and /submit-for-review by trusting agent judgment: collapse intent classification blocks to a single principle, remove the complexity scale definitions, and remove the resolution comment writing rules where the template already demonstrates the desired style.

Issue #148

@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

No issues found. Code looks correct and follows project conventions.

Details checked:

  • The new Step 3 (investigation findings gate) in Case B is correctly inserted between the human gate (Step 2) and branch checkout (now Step 4), with step numbering updated consistently through Step 5.
  • Case A step numbering (1–5) is unaffected.
  • The intent classification blocks in both Case A and Case B are correctly collapsed to single-principle sentences that preserve all four response categories (unconditional approval, conditions/questions, fresh start where applicable, abandonment).
  • The complexity scale removal is clean — no other section referenced or depended on those definitions.
  • The resolution writing rules removal in submit-for-review is safe — the inline template example already demonstrates the desired style (plain language, 1–3 sentences, non-technical audience), and the one actionable rule (#N form) is preserved.
  • The unconditional "Resuming work" comment is removed and replaced by the conditional investigation findings gate, matching the PR description.
  • All four adapter outputs (.claude, .agents, .cursor, .gemini) are synced with updated hashes for both start and submit-for-review.

@sebastientaggart
sebastientaggart merged commit 970ac89 into dev Apr 24, 2026
6 checks passed
@sebastientaggart
sebastientaggart deleted the feature/148-simplify-skill-rubrics branch April 24, 2026 13:18
@sebastientaggart sebastientaggart mentioned this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant